Preliminary support for member type representations with non-identifier qualifiers #62319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test macOS |
AnthonyLatsis
added
sugared types
AnthonyLatsis
force-pushed
the
sugar-type-members
branch
from
92c795c to
a9a998d
Compare
|
@swift-ci please smoke test macOS |
AnthonyLatsis
changed the title
|
@slavapestov ping |
AnthonyLatsis
force-pushed
the
sugar-type-members
branch
from
a9a998d to
ab70c39
Compare
|
@hborla ping |
|
@AnthonyLatsis thank you for the ping! This is on my TODO list to review today/tomorrow |
This was referenced Dec 25, 2022
AnthonyLatsis
force-pushed
the
sugar-type-members
branch
from
ab70c39 to
c2be634
Compare
|
@swift-ci please smoke test macOS |
hborla
approved these changes
Jan 3, 2023
|
@swift-ci please smoke test |
…lver::resolveIdentifierType`
…mponent` & `getMemberComponents` Also store the base component separately as an arbitrary `TypeRepr`.
AnthonyLatsis
force-pushed
the
sugar-type-members
branch
from
c2be634 to
1bb407a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
Thanks, Holly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly example:
[Int].Element. This patch simply paves the way — no functional changes except for that one diagnostic. Beside tackling the edge case of sugared qualifiers, this will later allow us to diagnose illegal type qualification in Sema and lay the foundation for expressing structural qualifiers in the future if the need arises.Partially resolves #59923