GettingStarted.md: A sprinkle of minor improvements #62371
Conversation
AnthonyLatsis
force-pushed
the
wakamole
branch
from
115bde5 to
2e46c01
Compare
| @@ -222,15 +232,7 @@ Phew, that's a lot to digest! Now let's proceed to the actual build itself! | |||
|
|
|||
| ### The actual build | |||
|
|
|||
| 1. Make sure you have Sccache running. | |||
| ```sh | |||
| sccache --start-server | |||
There was a problem hiding this comment.
Is this not needed anymore?
There was a problem hiding this comment.
build-script starts sccache for you if you pass --sccache (the invocation in the next step passes it).
There was a problem hiding this comment.
We only pass it in the macOS invocation though. On Linux sccache is presented as optional. I should probably add a sentence suggesting to add this option to the Linux invocation if the reader chose to install sccache.
There was a problem hiding this comment.
build-scriptstartssccachefor you if you pass--sccache(the invocation in the next step passes it).
Ah ok, maybe I just couldn't find it then. To me we were only validating with --show-stats
I should probably add a sentence suggesting to add this option to the Linux invocation if the reader chose to install
sccache.
Makes sense
There was a problem hiding this comment.
To me we were only validating with
--show-stats
I only just realized what you meant here. It happens --show-stats starts the server implicitly, so we’re covered.
AnthonyLatsis
force-pushed
the
wakamole
branch
from
2e46c01 to
0cb070a
Compare
AnthonyLatsis
force-pushed
the
wakamole
branch
from
0cb070a to
52c821a
Compare
|
@swift-ci please smoke test |
No description provided.