Add getGenericSignature() helper method to ArchetypeBuilder #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DougGregor @rjmccall Doug, John, could you have a look at this PR? This is the small of re-factoring we discussed a few days ago. Let me know if anything is missing. |
| /// \returns a generic signature build based on the provided list of | ||
| /// generic parameter types. | ||
| GenericSignature * | ||
| getGenericSignature(ArrayRef<GenericTypeParamType *> genercParamsTypes); |
There was a problem hiding this comment.
typo in the parameter name: generc
There was a problem hiding this comment.
@jtbandes Thanks, fixed! I force pushed the change.
This is just a small re-factoring moving some code around to make it possible for an ArchetypeBuilder to create a generic signature based on a provided list of generic parameter types and a set of archetype and requirements already known to the builder.
swiftix
force-pushed
the
wip-archetype-builder-refactoring
branch
from
9840327 to
52147ec
Compare
DougGregor
added a commit
that referenced
this pull request
Dec 18, 2015
Add getGenericSignature() helper method to ArchetypeBuilder
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…ride-swift-exec Support using `sk-swiftc-wrapper` that is not installed in the toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small re-factoring moving some code around to make it possible for an ArchetypeBuilder to create a generic signature based on a provided list of generic parameter types and a set of archetype and requirements already known to the builder.