Skip to content

build: avoid use of -external:I on Windows #63067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

compnerd
Copy link
Member

Avoid the use of the new -external:I to indicate the system headers for building the standard library on Windows as this will impact the header search order and due to the compiler swapping and mixed build, this breaks the runtime build on Windows.

Avoid the use of the new `-external:I` to indicate the system headers
for building the standard library on Windows as this will impact the
header search order and due to the compiler swapping and mixed build,
this breaks the runtime build on Windows.
@compnerd
Copy link
Member Author

CC: @etcwilde @bnbarham @shahmishal

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 4e7d311 into swiftlang:main Jan 18, 2023
@compnerd compnerd deleted the demanding-order branch January 18, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant