Skip to content

[libSwiftScan] Add V2 target info query API that takes compiler executable path as parameter #63132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jan 20, 2023

This new version takes the path to the compiler executable as a parameter, in order for libSwiftScan to compute compiler-relative portions of runtimeLibraryPaths, runtimeResourcePath. V1, without knowing the path to the compiler executable, produced incomplete sets of these paths.

@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test

@artemcm artemcm requested review from nkcsgexi and xymus January 20, 2023 19:11
@artemcm artemcm force-pushed the LibSwiftScanTargetInfoV2 branch from 586a860 to 1738e26 Compare January 20, 2023 20:04
@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test

@artemcm artemcm force-pushed the LibSwiftScanTargetInfoV2 branch from 1738e26 to 8542e73 Compare January 20, 2023 23:12
@artemcm
Copy link
Contributor Author

artemcm commented Jan 20, 2023

@swift-ci test

@artemcm artemcm force-pushed the LibSwiftScanTargetInfoV2 branch from 8542e73 to 306ade9 Compare January 21, 2023 01:12
@artemcm
Copy link
Contributor Author

artemcm commented Jan 21, 2023

@swift-ci test

…table path as parameter

This new version takes the path to the compiler executable as a parameter, in order for libSwiftScan to compute compiler-relative portions of runtimeLibraryPaths, runtimeResourcePath. V1, without knowing the path to the compiler executable, produced incomplete sets of these paths.
@artemcm artemcm force-pushed the LibSwiftScanTargetInfoV2 branch from 306ade9 to 1b4bc33 Compare January 23, 2023 17:40
@artemcm
Copy link
Contributor Author

artemcm commented Jan 23, 2023

@swift-ci smoke test

@artemcm artemcm merged commit eecde02 into swiftlang:main Jan 23, 2023
@artemcm artemcm deleted the LibSwiftScanTargetInfoV2 branch January 23, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant