[5.8] Sema: Avoid diagnosing missing imports for desugared typealiases in non-resilient modules #63279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-resilient modules. The following diagnostic is meant to prevent broken swiftinterfaces from being emitted: ``` 'SomeAlias' aliases 'SomeDesugaredType' and cannot be used here because 'DesugaredTypeModule' was not imported by this file; this is an error in Swift 6 ``` If the module exporting the reference to the typealias is non-resilient, though, then the module is not expected to have a buildable `swiftinterface` and therefore the diagnostic is superfluous. Resolves rdar://104749045
tshortli
added
🍒 release cherry pick
|
@swift-ci please test |
nkcsgexi
approved these changes
Jan 28, 2023
tshortli
deleted the
avoid-diagnosing-missing-import-for-desugared-typealias-in-non-resilient-modules-5.8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #63278.
The following diagnostic is meant to prevent broken swiftinterfaces from being emitted:
If the module exporting the reference to the typealias is non-resilient, though, then the module is not expected to have a buildable
swiftinterfaceand therefore the diagnostic is superfluous.Resolves rdar://104749045