[move-only] When performing borrow to destructure transform and failing, make sure we clean up appropriately. #63337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mits an error, we clean up the IR appropriately. This ensures we appropriately eliminate mark_must_check if we error and change copy_value -> explicit_copy_value.
…ecker rather than as a separate pass. The reason that I am doing this is I discovered that we emit worse quality diagnostics since if we emit an error while running the borrow to destructure transform, we want to do a complete cleanup to be safe (e.x.: converting copy_value -> explicit_copy_value). This causes the object checker to then not emit any additional diagnostics for other variables that were not impacted by the BorrowToDestructureTransform, reducing the quality of diagnostics in a significant way that isn't needed.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.