ABI Checker: avoid reporting module importation changes #63554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
1 similar comment
|
@swift-ci Please smoke test OS X platform |
ABI changes due to imported module changes should be reflected by other symbol changes. Reporting module import changes seems to be redundant.
|
@swift-ci please smoke test |
yyvch
added a commit
to yyvch/swift-package-manager
that referenced
this pull request
Jan 4, 2025
The two modified tests started failing after implementation change of the underlying tool. Imports stopped being considered breaking changes by itself in swiftlang/swift#63554.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI changes due to imported module changes should be reflected by other symbol changes. Reporting module import changes seems to be redundant.