[BuilderTransform] Rework missing buildWithLimitedAvailability detection
#63768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all of the branches of an `if` statement are joined together and hence produce the same type, that type should be used to check whether `buildWithAvailability` is required but missing regardless of availability condition kind. Resolves: swiftlang#63764
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
xedin
changed the title
buildWithAvailability detectionbuildWithLimitedAvailability detection
hborla
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all of the branches of an
ifstatement are joined together andhence produce the same type, that type should be used to check
whether
buildWithLimitedAvailabilityis required but missing regardless ofavailability condition kind.
Resolves: #63764