[Sema] Improving integer literal as boolean diagnostic #63799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving integer literal diagnostics to avoid
test for '!= 0' instead
as they don't make sense in a literal context.Also additionally covering cases where we currently produce a
Optional type 'Int?' cannot be used as a boolean; test for '!= nil' instead
on contextual mismatch in situations likeif 0? {}
in the same way.There is an extra case to cover on this
but that is a separate situation and is covered in another issue.
Resolves #63753