Skip to content

Update package name input and access scope check #64373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update package name input and access scope check #64373

merged 1 commit into from
Mar 15, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Mar 15, 2023

Allow Swift as a package name
Update AccessScope::isChildOf
Add more tests for package access level
Resolves rdar://106728606

Update AccessScope::isChildOf
Add more tests for package access level
Resolves rdar://106728606
@elsh
Copy link
Contributor Author

elsh commented Mar 15, 2023

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Mar 15, 2023

This PR addresses comments in #64230 as well as adds more tests. Merging this PR but feel free to leave any comments and they will be addressed in the upcoming PRs.

@elsh elsh merged commit 584919e into main Mar 15, 2023
@elsh elsh deleted the es-tests branch March 15, 2023 17:45
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth fixing the test, but besides that this looks good!

@@ -1,91 +1,202 @@
// RUN: %target-typecheck-verify-swift
// RUN: %target-swift-frontend -typecheck -disable-access-control %s
// RUN: %target-swift-frontend -typecheck -disable-access-control -package-name myPkg %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this used to test both the diagnostics and the disabling of access checking. I believe this dropped the check on the diagnostic. Can we keep a -verify check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back in #64408

@nkcsgexi
Copy link
Contributor

Thank you for testing this extensively, Ellie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants