[interop] C++ destination record should be destroyed before being cop… #64397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied into during assignWithCopy / assignWithTake
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
zoecarver
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Nit, non-blocking: the other special member tests are in Cxx/value-witness-table.
zoecarver
approved these changes
Mar 15, 2023
|
Thanks Alex. This LGTM. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
hyp
force-pushed
the
eng/destroy-before-assigncopytake
branch
from
46d6d3e to
7fef4b6
Compare
|
@swift-ci please test |
|
@swift-ci please test macos platform |
|
@swift-ci please test |
hyp
force-pushed
the
eng/destroy-before-assigncopytake
branch
from
596ff6f to
3e4669b
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ied into during assignWithCopy / assignWithTake