Sema: Don't diagnose declarations more available than unavailable container #64515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer. It turns out that we must allow declarations with `introduced:` availability nested inside of other declarations that are `unavailable` in order to influence weak linking. Stop diagnosing declarations as being more available than their unavailable containers and revert some changes to availability inference that were designed to avoid creating these nestings but caused regressions for declarations marked `@_spi_available.` Reverts parts of swiftlang#64310, swiftlang#64015, and swiftlang#62900.
|
@swift-ci please smoke test |
This was referenced Mar 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we must allow declarations with
introduced:availability nested inside of other declarations that areunavailablein order to influence weak linking. Stop diagnosing declarations as being more available than their unavailable containers and revert some changes to availability inference that were designed to avoid creating these nestings but caused regressions for declarations marked@_spi_available.Reverts parts of #64310, #64015, and #62900.