🍒[cxx-interop] Treat un-instantiated templated types as unsafe #64918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining whether a C++ method is safe to be imported, we look at its return type to see if it stores any pointers in its fields. If the type is templated, we might not have its definition available yet. Unfortunately we cannot instantiate it on the spot, since the Clang AST would be read and written at the same time. Let's stay on the safe side and treat such methods as unsafe. rdar://107609381 (cherry picked from commit c813254)
egorzhdan
changed the title
|
@swift-ci please test |
hyp
approved these changes
Apr 4, 2023
|
@swift-ci please test Windows |
|
@swift-ci please test macOS |
DougGregor
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This adjusts the C++ method importing logic to treat methods that return templated types as unsafe if the template was not instantiated. Previously such methods were treated as safe, even if the templated return type stores pointers in its fields.
Scope: This makes certain C++ methods unavailable that were previously available in Swift.
Risk: Low: C++ interop is an experimental feature that is not used in production.
Testing: Added LIT tests.
rdar://107609381
(cherry picked from commit c813254)