[5.9][SourceKit] Pass 'swiftc' path to Driver when creating frontend args #65151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver uses its path to derive the plugin paths (i.e. 'lib/swift/host/plugins' et al.) Previously it was a constant string 'swiftc' that caused SourceKit failed to find dylib plugins in the toolchain. Since 'SwiftLangSupport' knows the swift-frontend path, use it, but replacing the filename with 'swiftc', to derive the plugin paths. rdar://107849796 (cherry picked from commit 3517db4)
|
@swift-ci Please test |
airspeedswift
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #65068 into
release/5.9Explanation:
libDriveruses its path to derive the plugin paths (i.e.lib/swift/host/plugins) Previously it was a constant stringswiftcnot an actual path, that caused SourceKit failed to find dylib plugins in the toolchain. SinceSwiftLangSupportknows the swift-frontend path, use it, but replacing the filename withswiftc, to derive the plugin paths.Scope: Legacy
libDriverclients usinggetSingleFrontendInvocationFromDriverArgumentscurrently only SourceKitRisk: Low
Testing: Added regression test cases
Issue: rdar://107849796
Reviewer: Alex Hoppen (@ahoppen)