Skip to content

[5.9][SE-0393] Enable parameter packs for generic functions. #65215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Apr 16, 2023

  • Explanation: Now that SE-0393 is accepted, enable parameter packs for generic functions by default. The -enable-experimental-feature VariadicGenerics flag still exists and is required for generic types with parameter packs. This change also adds a separate TupleConformances flag, as the current experimental implementation of tuple conformances previously also used the VariadicGenerics flag.
  • Scope: Impacts new code using parameter packs. Does not impact existing code other than a few changes to diagnostics when repeat is parsed as a pack expansion expression.
  • Issue: rdar://103147562
  • Risk: Very low.
  • Testing: Updated existing parameter packs tests to remove -enable-experimental-feature VariadicGenerics.
  • Reviewer: @xedin
  • Main branch PR: [SE-0393] Enable parameter packs for generic functions. #65214

hborla added 3 commits April 15, 2023 21:53
The VariadicGenerics flag still exists and is required for generic types
with parameter packs

(cherry picked from commit 0ed4b33)
…ric types

with parameter packs.

(cherry picked from commit e48a9b5)
@hborla hborla requested a review from a team as a code owner April 16, 2023 05:10
@hborla
Copy link
Member Author

hborla commented Apr 16, 2023

@swift-ci please test

@hborla hborla merged commit 495c6e4 into swiftlang:release/5.9 Apr 17, 2023
@hborla hborla deleted the 5.9-enable-parameter-pack-functions branch April 17, 2023 01:44
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants