Fix pointer auth issues for discarding task group operation pointer #65220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
|
This "fix" does not fix the issue. |
|
I was verifying wrong -- confirmed this fixes the pointer auth issue ✅ ❗ |
|
@swift-ci please smoke test |
mikeash
approved these changes
Apr 17, 2023
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Apr 18, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one low churn idea to fix pointer auth for the discarding task group -- since it seems the fact that we're passing a
-> Voidrather than a-> Tmay be causing issues.Meanwhile I'm looking into a new builtin that would be dedicated to
-> Void.I'm not 100% sure this resolves the issue though, so more verification might be necesary.