Skip to content

[Serialization] Write down SPI only dependencies as required in swiftmodules #65337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Apr 21, 2023

Ensure clients load transitive @_spiOnly dependencies by writing them down in the same category as default imports in swiftmodules. These dependencies will be required for clients loading from swiftmodule and swiftinterface, but hidden from clients loading from a public swiftinterface.

The lack of this information was revealed by #64260, as previously clients would see @_spiOnly dependencies as normal dependencies.

rdar://108326858

@xymus xymus requested a review from tshortli April 21, 2023 01:05
@xymus
Copy link
Contributor Author

xymus commented Apr 21, 2023

@swift-ci Please smoke test

@xymus xymus merged commit e8a5fa4 into swiftlang:main Apr 21, 2023
@xymus xymus deleted the spi-only-dep branch April 21, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants