Skip to content

[Macros] Verify '-load-plugin-library' precedes '-plugin-path' #65601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 2, 2023

The actual change was done in #65453.
Just adding a test case to prevent regressions.

rdar://108285056

@rintaro
Copy link
Member Author

rintaro commented May 2, 2023

@swift-ci Please smoke test

@rintaro rintaro force-pushed the macros-test-rdar108285056 branch from a579dfd to e1be938 Compare May 2, 2023 23:13
@rintaro
Copy link
Member Author

rintaro commented May 2, 2023

@swift-ci Please smoke test

@rintaro rintaro requested a review from bnbarham May 2, 2023 23:14
// RUN: %t/src/MacroDefinition.int.swift \
// RUN: -g -no-toolchain-stdlib-rpath

//#-- Check '-load-plugin-library' precedes '-plugin-path'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takes precedence would be clearer to me, but I'm not overly fussed.

Add a test case to prevent regressions.

rdar://108285056
@rintaro rintaro force-pushed the macros-test-rdar108285056 branch from e1be938 to 766278b Compare May 3, 2023 00:04
@rintaro
Copy link
Member Author

rintaro commented May 3, 2023

@swift-ci Please smoke test

@rintaro rintaro merged commit 922f884 into swiftlang:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants