[CodeCompletion] Only show type annotations for macros that return non-void #65637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
bnbarham
reviewed
May 4, 2023
| @@ -65,12 +65,12 @@ import MacroDefinitions | |||
| @#^STRUCT_ATTR?check=NOMINAL_ATTR^# struct S{} | |||
| // NOMINAL_ATTR-NOT: freestanding | |||
| // NOMINAL_ATTR-NOT: AttachedAccessorMacro | |||
| // NOMINAL_ATTR-DAG: Decl[Macro]/{{.*}}/TypeRelation[Convertible]: AttachedMemberMacro[#Void#]; name=AttachedMemberMacro | |||
There was a problem hiding this comment.
The TypeRelation is for scoring above other types in @ position, so should still be there. Is that not the case?
…n-void Showing the type annotation only makes sense if they are not `Void`. That’s consistent with functions where we also don’t show a `Void` return type. Most importantly, we shouldn’t be showing a `Void` type annotation for attached macros. rdar://108870970
ahoppen
force-pushed
the
ahoppen/macro-type-annotation
branch
from
6f1c942 to
c140fe4
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing the type annotation only makes sense if they are not
Void. That’s consistent with functions where we also don’t show aVoidreturn type. Most importantly, we shouldn’t be showing aVoidtype annotation for attached macros.rdar://108870970