[test] Take care of change out of deleted directories #65664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
QuietMisdreavus
approved these changes
May 4, 2023
These two tests were changing directories into the temporary, never changing out of there, and then recreating the temporary, which left the rest of the test executing in a non-existing directory. Modify those tests to change out to the previous directory and avoid executing any command in a non-existing directory.
drodriguez
force-pushed
the
cd-out-of-deleted-dirs
branch
from
ee26ca0 to
a2c6db3
Compare
|
@swift-ci please test |
|
Windows did not understood |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests were changing directories into the temporary, never changing out of there, and then recreating the temporary, which left the rest of the test executing in a non-existing directory.
Modify those tests to change out to the previous directory and avoid executing any command in a non-existing directory.