Skip to content

[5.9][Runtime] Print type names in escape-from-deinit messages. #65695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented May 5, 2023

In addition to giving the object's address, we can print the name of its type (since the object is still live at this point).

rdar://108882759

In addition to giving the object's address, we can print the name of its
type (since the object is still live at this point).

rdar://108882759
@al45tair al45tair requested a review from a team as a code owner May 5, 2023 10:57
@al45tair
Copy link
Contributor Author

al45tair commented May 5, 2023

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented May 5, 2023

Explanation: Adds the name of the class to the message you get if an object tries to escape deinit.
Risk: Only affects a fatal error message.
Original PR: #65693
Reviewed by: @mikeash
Resolves: rdar://108882759
Tests: test/Runtime/deinit_escape.swift tests the fatal error itself.

@al45tair al45tair added the 🍒 release cherry pick Flag: Release branch cherry picks label May 11, 2023
@al45tair al45tair requested a review from mikeash May 17, 2023 10:43
@tbkka tbkka changed the title [Runtime] Print type names in escape-from-deinit messages. [5.9][Runtime] Print type names in escape-from-deinit messages. May 17, 2023
@al45tair al45tair merged commit 6c53fcf into swiftlang:release/5.9 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants