[5.9] Fix indexing constructors with generic parameters (#65597) #65721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Previously in the case of a constructor like `A<Int>(value: 1)` `Fn->getLoc()` returned the location of `>(value: 1)` while the actual location we're looking for is correctly the start of `A<Int>(value: 1)`. This adjusts the location we're looking up to use the start location of the constructor instead. Fixes: swiftlang#54532 (cherry picked from commit f5fbee2 / swiftlang#65597)
|
@swift-ci please test |
|
@DougGregor can I bug you for a review here as the 5.9 swift compiler release manager? |
DougGregor
approved these changes
May 30, 2023
keith
deleted the
ks/5.9-fix-indexing-constructors-with-generic-parameters-65597
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the case of a constructor like
A<Int>(value: 1)Fn->getLoc()returned the location of>(value: 1)while the actual location we're looking for is correctly the start ofA<Int>(value: 1). This adjusts the location we're looking up to use the start location of the constructor instead.Fixes: #54532
(cherry picked from commit f5fbee2 / #65597)