[CSSimplify] Detect and diagnose conformance failures related to AnyHashable conversion #65806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashable conversion Failure of an argument to AnyHashable parameter to conform to Hashable protocol should be detected in `simplifyConformsToConstraint` and fixed there. Doing so requires impact assessment adjustment because regular conformance requirements have default impact of 1, this is going to have argument impact of 2 not avoid clashing with other failures.
|
@swift-ci please test |
… the overloads matched
|
@swift-ci please test |
hborla
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure of an argument to AnyHashable parameter to conform to Hashable
protocol should be detected in
simplifyConformsToConstraintand fixedthere.
Doing so requires impact assessment adjustment because regular conformance
requirements have default impact of 1, this is going to have argument
impact of 2 not avoid clashing with other failures.
Resolves: rdar://108977234