[Observation] Refinements for init, peer macros, and qualified type emissions #66288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fixes for the following:
Ensure type access is qualified to the module name. e.g. when an imported module ALSO defines
Observablemake sure the macros don't cause ambiguity.Transition to peer macros instead of arbitrary member. This removes the arbitrary member emission from using
@Observableand favors the peer macro instead.Lift the initializer requirement by utilizing init accessors for fully formed definite initialization. This removes the error case where types need fully defined initialization of properties. This is dependent upon #66283