Skip to content

Cleanups of various bash scripts #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2015
Merged

Cleanups of various bash scripts #670

merged 6 commits into from
Dec 20, 2015

Conversation

practicalswift
Copy link
Contributor

Fixes:

  • Use of > instead of -gt for numerical comparison. > is used for string comparisons.
  • Superfluous $ in arithmetic variables.
  • Use of discouraged back-tick execution (instead of recommended $(cmd))

@gribozavr
Copy link
Contributor

@practicalswift LGTM, but utils/install-package-helper.sh is old and unused, let's just remove it.

@practicalswift
Copy link
Contributor Author

@gribozavr Added commit to remove utils/install-package-helper.sh. May I remove utils/install-test-script.sh too?

@gribozavr
Copy link
Contributor

@practicalswift Yes, good catch, that one should go, too.

gribozavr added a commit that referenced this pull request Dec 20, 2015
@gribozavr gribozavr merged commit 3330352 into swiftlang:master Dec 20, 2015
@gribozavr
Copy link
Contributor

Thank you!

@practicalswift
Copy link
Contributor Author

@gribozavr Another question - may I delete utils/demo-tool from the repo? Seems like a nice tool, but I'm not sure the Swift repo is the right home for it :-)

freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants