Skip to content

[5.9][Macros] Unify PluginMessages.swift #67038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 29, 2023

cherry-pick #67025 into release/5.9

swift-syntax change swiftlang/swift-syntax#1866

  • Explanation: ASTGen in swift repo and SwiftCompilerPluginMessageHandling in swift-syntax used to have separate PluginMessages.swift. When we change the executable plugin IPC message format, we needed to change both files exactly the same way. That was confusing and there was no benefit of having separate files in 2 repositories. Instead, expose that message types from swift-syntax and use it from swift repo. So that we have the single source of truth in swift-syntax
  • Scope: Executable plugin IPC messaging.
  • Risk: Low. ASTGen now import the module in swift-syntax repo which is already built/installed in the toolchain
  • Testing: Passes current test suites
  • Issue: rdar://111538595
  • Reviewer: Doug Gregor (@DougGregor)

Use PluginMessages.swift in swift-syntax consistently.

(cherry picked from commit 3e9c253)
@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2023

swiftlang/swift-syntax#1866
@swift-ci Please test

@rintaro rintaro merged commit a550fa8 into swiftlang:release/5.9 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants