Skip to content

[5.9] [SymbolGraphGen] don't emit symbols and protocols from unconditionally unavailable extensions #67540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #67539

Explanation: Prevents protocols and symbols added via unconditionally-unavailable extensions from appearing in symbol graphs.
Scope: Affects documentation of projects that use this pattern to forbid protocols like Sendable.
Issue: rdar://112137607
Risk: Low. This fix is targeted to SymbolGraphGen, doesn't affect normal compilation, and hides symbols and relationships that should be considered unavailable.
Testing: Automated tests have been added to ensure the new behavior.
Reviewer: @daniel-grumberg

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner July 26, 2023 17:11
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test Linux

@QuietMisdreavus QuietMisdreavus merged commit e02171d into release/5.9 Jul 27, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/unavailable-conformance branch July 27, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants