Skip to content

[cxx-interop] test, enable more tests on windows #67603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[cxx-interop] test, enable more tests on windows #67603

merged 1 commit into from
Jul 31, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 28, 2023

These tests require the C++ standard library

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Jul 28, 2023
@hyp hyp requested review from zoecarver and egorzhdan as code owners July 28, 2023 20:14
@hyp
Copy link
Contributor Author

hyp commented Jul 28, 2023

@swift-ci please test

@hyp
[cxx-interop] test, enable more tests on windows
cf94366 
These tests require the C++ standard library
@hyp hyp force-pushed the window-me-timbers branch from b349f75 to cf94366 Compare July 28, 2023 23:02
@hyp
Copy link
Contributor Author

hyp commented Jul 28, 2023

vector test is still borked somehow, will need to investigate. anyways, this should work.

@hyp
Copy link
Contributor Author

hyp commented Jul 28, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 29, 2023

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member

@swift-ci please test macOS platform

egorzhdan
egorzhdan approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hyp hyp merged commit c2f0fde into swiftlang:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyp @compnerd @egorzhdan