Fix handling of none value stores to non-trivial enums in Mem2Reg #68325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow none values to be stored to a non-trivial enum. For such store_borrow, `LiveValues::forValues` used an Owned storage type, but endLexicalLifetime expected Guaranteed storage type, leading to a compiler crash. For store_borrow, use the LiveValues::forGuaranteed and for store use LiveValues::forOwned to avoid this. Fixes rdar://114390472
meg-gupta
force-pushed
the
fixnonestoremem2reg
branch
from
3b8b870 to
c89dcd8
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow none values to be stored to a non-trivial enum. For such a store_borrow,
LiveValues::forValuesused anOwnedstorage type, but endLexicalLifetime expectedGuaranteedstorage type, leading to a compiler crash.For
store_borrow, use theLiveValues::forGuaranteedand for store useLiveValues::forOwnedto avoid this.Fixes rdar://114390472