[5.10][CSSimplify] Determine whether type is know Foundation entity in a safer way #68991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer way Instead of trying to get string representation of the type itself, let's just get it based on the type name, which works well with the list of types we have. Resolves: rdar://113675093 (cherry picked from commit b83a73d)
|
@swift-ci please test |
hborla
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68964
Addresses a common source of crashes in 5.9
Instead of trying to get string representation of the type itself,
let's just get it based on the type name, which works well with
the list of types we have.
Scope: Based on the stacktrace - expressions with some generic types that do not satisfy contextual conformance requirements.
Main Branch PR: [CSSimplify] Determine whether type is know Foundation entity in a sa… #68964
Resolves: rdar://113675093
Risk: Low
Reviewed By: @hborla
Testing: No tests because this is a speculative fix.
Resolves: rdar://113675093
(cherry picked from commit b83a73d)