Skip to content

[test][IRGen] Split returnaddress related check into a separate file #69045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 8, 2023

llvm.returnaddress is unavailable on WebAssembly, so split the part from access_markers.sil to exclude it conditionally.

@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test

@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 9, 2023 14:46
@MaxDesiatov MaxDesiatov requested a review from al45tair October 9, 2023 14:47
@MaxDesiatov MaxDesiatov added WebAssembly Platform: WebAssembly IRGen LLVM IR generation test suite Area: test suite labels Oct 9, 2023
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 12, 2023

Does anyone have any concern about merging this?

@MaxDesiatov MaxDesiatov requested a review from etcwilde October 12, 2023 21:21
@kateinoigakukun kateinoigakukun merged commit 8fa3d30 into swiftlang:main Oct 16, 2023
@kateinoigakukun kateinoigakukun deleted the pr-6b4e2fcfd7c38a04580c5b5f8c08e565992a1040 branch October 16, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRGen LLVM IR generation test suite Area: test suite WebAssembly Platform: WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants