Don't keep generic versions of PtrAuth functions alive #69373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't support generating code for ptrauth builtins with generic inputs (or non-constant inputs). We rely on specialization/inlining for such code to work. After a recent commit (swiftlang#68843 ) code in IRGen keeps internal unreferenced functions alive for debugging purposes. This is a problem for the generic functions in PtrAuth.swift using ptrauth builtins. Opt out of this new behavior by sprinkling some pixie dust. Fixes debug swift standard library builds targeting arm64e. rdar://117411740
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support generating code for ptrauth builtins with generic inputs (or non-constant inputs). We rely on specialization/inlining for such code to work.
After a recent commit (#68843 ) code in IRGen keeps internal unreferenced functions alive for debugging purposes.
This is a problem for the generic functions in PtrAuth.swift using ptrauth builtins.
Opt out of this new behavior by sprinkling some pixie dust.
Fixes debug swift standard library builds targeting arm64e.
rdar://117411740