[swift-inspect] Add an option to print mangled names while dumping generic metadata. #69488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w6sec
requested review from
mikeash,
al45tair,
compnerd and
a team
as code owners
|
@swift-ci please test |
mikeash
requested changes
Oct 30, 2023
tools/swift-inspect/Sources/swift-inspect/RemoteMirror+Extensions.swift
Outdated
Show resolved
Hide resolved
tools/swift-inspect/Sources/swift-inspect/Operations/DumpGenericMetadata.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
mikeash
approved these changes
Oct 31, 2023
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
--mangledoption to print mangled names while dumping generic metadata. We also cross-check to make sure pre-specialized generic metadata strictly exists in theDATA,AUTH, orTEXTsegments of the images, and report on errors.