SIL: Fix a crash during access path verification #69799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The access path verification optimizer pass calls `getStaticallyInitializedVariable()`, which was written assuming that the given `SILFunction` would always have a valid return basic block. When the `-unavailable-decl-optimization=stub` option is passed to the frontend, though, any function generated for a declaration marked `@available(*, unavailable)` is rewritten to trap by calling a function that returns `Never`. Therefore the rewritten functions do not have return blocks and passing these functions to `getStaticallyInitializedVariable()` would result in the compiler invoking undefined behavior. Resolves rdar://118281508
tshortli
force-pushed
the
access-path-verification-unavailable-stub-crash
branch
from
bfa6fa6 to
da3af76
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The access path verification optimizer pass calls
getStaticallyInitializedVariable(), which was written assuming that the givenSILFunctionwould always have a valid return basic block. When the-unavailable-decl-optimization=stuboption is passed to the frontend, though, any function generated for a declaration marked@available(*, unavailable)is rewritten to trap by calling a function that returnsNever. Therefore the rewritten functions do not have return blocks and passing these functions togetStaticallyInitializedVariable()would result in the compiler invoking undefined behavior.Resolves rdar://118281508