Skip to content

[test] Replace %swift-build-cxx-plugin with %swift-build-c-plugin #70188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

drodriguez
Copy link
Contributor

As pointed out in #70136 (comment) the substitution name does not make sense because we are compiling C code, not C++.

This should not introduce any behavioural changes.

As pointed out in swiftlang#70136 (comment)
the substitution name does not make sense because we are compiling
C code, not C++.

This should not introduce any behavioural changes.
@drodriguez drodriguez requested a review from bnbarham December 2, 2023 20:42
@drodriguez
Copy link
Contributor Author

@swift-ci please test

@drodriguez drodriguez merged commit 5d2e4a3 into swiftlang:main Dec 4, 2023
@drodriguez drodriguez deleted the change-cxx-with-c branch December 4, 2023 17:24
@bnbarham
Copy link
Contributor

bnbarham commented Dec 4, 2023

Thanks!

Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
…iftlang#70188)

As pointed out in swiftlang#70136 (comment)
the substitution name does not make sense because we are compiling
C code, not C++.

This should not introduce any behavioural changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants