Skip to content

[Concurrency] Compute actor isolation for var decls before checking decl attributes. #70222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Dec 5, 2023

The compiler happened to accept invalid property wrapper code because inferred nonisolated attributes were applied after checking declaration attributes. Fix this by forcing actor isolation computation in the primary declaration checker before checking attributes.

@hborla
Copy link
Member Author

hborla commented Dec 5, 2023

@swift-ci please smoke test

@hborla
Copy link
Member Author

hborla commented Dec 5, 2023

@swift-ci please test source compatibility

@hborla
Copy link
Member Author

hborla commented Dec 5, 2023

@swift-ci please smoke test

@hborla
Copy link
Member Author

hborla commented Dec 5, 2023

@swift-ci please test source compatibility

@hborla hborla merged commit a4fe719 into swiftlang:main Dec 5, 2023
@hborla hborla deleted the implicit-nonisolated-property-wrapper branch December 5, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant