Skip to content

Do not skip earlyswiftdriver in SwiftPM Linux CI Preset #70996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jan 18, 2024

No description provided.

@artemcm artemcm requested a review from MaxDesiatov January 18, 2024 22:32
@artemcm
Copy link
Contributor Author

artemcm commented Jan 18, 2024

@swift-ci test

@MaxDesiatov MaxDesiatov changed the title Do not skip earlyswiftdriver in SPM Linux CI Preset Do not skip earlyswiftdriver in SwiftPM Linux CI Preset Jan 18, 2024
@MaxDesiatov
Copy link
Contributor

Nitpicky title update to make search easier: official name is SwiftPM and when searching for SwiftPM in issues/PRs, anything that uses "SPM" won't show up in search results.

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue description is empty, I don't have much experience with the toolchain build system, I don't know where documentation for this build-script flag is, or what this flag is doing, so I'm not sure how to review this. What impact does it have?

@MaxDesiatov MaxDesiatov added the build-script Area → utils: The build script label Jan 18, 2024
@artemcm artemcm force-pushed the DoNotSkipEarlyDriverLinuxPreset branch from 6999b03 to 58ee812 Compare January 18, 2024 23:14
@artemcm
Copy link
Contributor Author

artemcm commented Jan 18, 2024

Issue description is empty, I don't have much experience with the toolchain build system, I don't know where documentation for this build-script flag is, or what this flag is doing, so I'm not sure how to review this. What impact does it have?

https://github.com/apple/swift/blob/e5742be3afb5456357ba548b25f0d9bbb7c70ca5/utils/build_swift/build_swift/driver_arguments.py#L695

This flag skips building the "early" swift driver which gets built using the host toolchain and gets used as the default driver in the compiler build directory. Building the early swift driver is otherwise the default today, and I'm not sure if there's a good reason it gets skipped here.

@artemcm
Copy link
Contributor Author

artemcm commented Jan 18, 2024

We should test this by launching a CI run in the SwiftPM repo against this change, if possible, too.

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Jan 18, 2024

Thanks for the explanation! I've just started a cross-repo Linux job here swiftlang/swift-package-manager#7273 (comment)

@artemcm
Copy link
Contributor Author

artemcm commented Jan 18, 2024

Thanks for the explanation! I've just started a cross-repo Linux job here apple/swift-package-manager#7273 (comment)

Thanks!

@artemcm
Copy link
Contributor Author

artemcm commented Jan 18, 2024

@swift-ci test

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@artemcm artemcm merged commit f7dcecd into swiftlang:main Jan 19, 2024
@artemcm artemcm deleted the DoNotSkipEarlyDriverLinuxPreset branch January 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-script Area → utils: The build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants