-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Do not skip earlyswiftdriver
in SwiftPM Linux CI Preset
#70996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not skip earlyswiftdriver
in SwiftPM Linux CI Preset
#70996
Conversation
@swift-ci test |
earlyswiftdriver
in SPM Linux CI Presetearlyswiftdriver
in SwiftPM Linux CI Preset
Nitpicky title update to make search easier: official name is SwiftPM and when searching for SwiftPM in issues/PRs, anything that uses "SPM" won't show up in search results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue description is empty, I don't have much experience with the toolchain build system, I don't know where documentation for this build-script
flag is, or what this flag is doing, so I'm not sure how to review this. What impact does it have?
6999b03
to
58ee812
Compare
This flag skips building the "early" swift driver which gets built using the host toolchain and gets used as the default driver in the compiler build directory. Building the early swift driver is otherwise the default today, and I'm not sure if there's a good reason it gets skipped here. |
We should test this by launching a CI run in the SwiftPM repo against this change, if possible, too. |
Thanks for the explanation! I've just started a cross-repo Linux job here swiftlang/swift-package-manager#7273 (comment) |
Thanks! |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
No description provided.