Add a test for the SIL type equality assert failures due to opaque re… #71187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
…turn types This is the test part of swiftlang#70865 which was fixed by the commit swiftlang@8d649a2
hjyamauchi
force-pushed
the
win-865-test
branch
from
43d9ceb to
09bf38c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows platform |
1 similar comment
|
@swift-ci Please test Windows platform |
|
@swift-ci please test Windows platform |
|
@slavapestov I think this is what you requested here. Can you take a look? |
compnerd
approved these changes
Feb 6, 2024
| // RUN: %target-swift-frontend -swift-version 5 -disable-availability-checking -c %S/Inputs/opaque_return_type_equality_input.swift -emit-module-path %t/opaque_return_type_equality_input.swiftmodule -I %t -O -module-name opaque_return_type_equality_input -o %t/opaque_return_type_equality_input.o | ||
| // RUN: %target-swift-frontend -swift-version 5 -disable-availability-checking -c %S/opaque_return_type_equality.swift -emit-module-path %t/opaque_return_type_equality.swiftmodule -I %t -O -module-name opaque_return_type_equality -o %t/opaque_return_type_equality.o | ||
|
|
||
| // Check that the SIL type equality check asserts don't fail between the opaque return types and their underlying types. |
There was a problem hiding this comment.
Does this not require an additional flag to be passed? Something along the lines of -enable-sil-verify-all or -sil-verify-all.
There was a problem hiding this comment.
I was able to trigger the assert failure without one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…turn types.
This is the test part of #70865 which was fixed by the commit
8d649a2