Ncgenerics test fixes kavon v4 #71438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v4
branch
from
883745b to
89d3bff
Compare
|
@swift-ci please test |
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v4
branch
from
89d3bff to
d22b98b
Compare
|
@swift-ci please test |
|
@swift-ci smoke test |
While certain kinds of enums synthesize Equatable, Hashable, and RawRepresentable conformances, we can't yet permit noncopyable types to synthesize those until we upgrade those protocols themselves to not require `Copyable` conformers. For example, Equatable needs to be changed in the stdlib to be `protocol Equatable: ~Copyable`, etc. I'm deferring upgrade work until a bit later.
There's no good reason to permit them. Conformances like Copyable and Sendable are pervasive, so it's as though we are permitting extensions of `Any`. Until there's a good argument in favor of such extensions, remove the capability now.
Functions can in fact conform to some protocols, notably, marker protocols. Dynamically they have no influence on whether the cast will succeed or not, as there is no way to tell if a type conforms to such a protocol at runtime. But we should check them statically because they otherwise can be cast to Any eventually.
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v4
branch
from
d22b98b to
3dda59f
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more fixes for tests that fail under NoncopyableGenerics