Skip to content

[ExternalGenericMetadataBuilder] Support ARM64e fixups. #71522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Feb 9, 2024

Add ptrauth attributes to the witness tables and descriptor pointers, and have the test support ARM64e.

rdar://122660111

@mikeash mikeash requested a review from al45tair as a code owner February 9, 2024 22:07
@mikeash
Copy link
Contributor Author

mikeash commented Feb 9, 2024

@swift-ci please test

@mikeash mikeash force-pushed the externalgenericmetadatabuilder-arm64e-fix branch from 645b2ba to 327e16c Compare February 12, 2024 14:24
@mikeash
Copy link
Contributor Author

mikeash commented Feb 12, 2024

@swift-ci please test

@mikeash mikeash force-pushed the externalgenericmetadatabuilder-arm64e-fix branch from 327e16c to cdf147e Compare February 13, 2024 18:59
@mikeash
Copy link
Contributor Author

mikeash commented Feb 13, 2024

We hit an assertion failure due to some missing error checking in GenericMetadataBuilder, added that now.

@mikeash
Copy link
Contributor Author

mikeash commented Feb 13, 2024

@swift-ci please test

@mikeash mikeash enabled auto-merge February 13, 2024 20:06
@mikeash mikeash force-pushed the externalgenericmetadatabuilder-arm64e-fix branch from cdf147e to 6f66fc9 Compare February 13, 2024 21:46
@mikeash
Copy link
Contributor Author

mikeash commented Feb 14, 2024

@swift-ci please test

Add ptrauth attributes to the witness tables and descriptor pointers, and have the test support ARM64e.

rdar://122660111
@mikeash mikeash force-pushed the externalgenericmetadatabuilder-arm64e-fix branch from 6f66fc9 to 89e5a80 Compare February 14, 2024 14:53
@mikeash
Copy link
Contributor Author

mikeash commented Feb 14, 2024

@swift-ci please test

@mikeash mikeash merged commit 5ce824f into swiftlang:main Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants