Add missing checks for nullptr. #71623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
We got crash reports from LLDB where protocolList is a nullptr when demangling a symbolic reference. While we're also investigating the root cause of the issue, the code in MetadataReader should also not just crash with such input. rdar://122698966
adrian-prantl
force-pushed
the
122698966
branch
from
9b7201e to
e901376
Compare
|
@swift-ci test |
|
LGTM. Really makes you miss Swift's optional chaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got crash reports from LLDB where protocolList is a nullptr when demangling a symbolic reference. While we're also investigating the root cause of the issue, the code in MetadataReader should also not just crash with such input.
rdar://122698966
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves #NNNNN, fix apple/llvm-project#MMMMM.