stdlib: Avoid condfails resulting from typed throws adoption #71802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard library's swiftinterface must temporarily remain buildable when `$TypedThrows` evaluates to false since there are still supported Swift 5.11 compilers that did not have the feature enabled by default. Declarations using typed throws in their signatures are guarded in printed swiftinterface files with `#if $TypedThrows` and therefore `@inlinable` code that uses those declarations must also be conditionalized on `$TypedThrows`.
|
@swift-ci please smoke test |
hborla
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library's swiftinterface must temporarily remain buildable when
$TypedThrowsevaluates to false since there are still supported Swift 5.11 compilers that did not have the feature enabled by default. Declarations using typed throws in their signatures are guarded in printed swiftinterface files with#if $TypedThrowsand therefore@inlinablecode that uses those declarations must also be conditionalized on$TypedThrows.Addresses fallout from #69771 and #70971.