Skip to content

[stdlib] convert withUnsafeMutablePointer() to typed throws #72089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Mar 5, 2024

Part of the ongoing conversion of standard library rethrows functions, after SE-0413.

This converts the top-level withUnsafeMutablePointer(to:_:) function.
Its corresponding no-stack-protection equivalent is omitted here, due to a compiler issue (rdar://121289127).

@glessard glessard requested a review from a team as a code owner March 5, 2024 11:25
@glessard
Copy link
Contributor Author

glessard commented Mar 5, 2024

@swift-ci please test

1 similar comment
@glessard
Copy link
Contributor Author

glessard commented Mar 5, 2024

@swift-ci please test

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glessard
Copy link
Contributor Author

glessard commented Mar 8, 2024

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Mar 8, 2024

The previous failures should be fixed by #72152

@glessard glessard enabled auto-merge March 8, 2024 00:41
Update test/api-digester/stability-stdlib-abi-without-asserts.test
@glessard
Copy link
Contributor Author

glessard commented Mar 8, 2024

@swift-ci please test

@glessard glessard merged commit 78273b2 into swiftlang:main Mar 8, 2024
@glessard glessard deleted the toplevel-withUMP-typed-throws branch March 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants