[Refactoring] Skip failed witness decls in "add codable implementation" #72392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
When there are problems in the properties in the target type, witness methods may not be synthesized. Don't try to add such methods. swiftlang#72387
rintaro
force-pushed
the
refactoring-codable-sr72387
branch
from
7cffa9a to
7177055
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Mar 18, 2024
ahoppen
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are problems in the properties in the target type, witness methods may not be synthesized. Don't try to add such methods.
Fixes #72387