[6.0] SILGen: Emit empty type initialization for conditionally-copyable type inits. #72468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inits. Fix the check here to go by `isMoveOnly` on the lowered type rather than `canBeCopyable` on the declaration so that we correctly emit the semantic initialization for types that are `~Copyable` in their most generic form. Fixes rdar://125101955.
jckarter
force-pushed
the
init-conditionally-copyable-empty-type-6.0
branch
from
ffc1d4a to
355c0c9
Compare
|
@swift-ci Please test |
tbkka
approved these changes
Mar 20, 2024
nate-chandler
approved these changes
Mar 20, 2024
kavon
approved these changes
Mar 20, 2024
kalebers
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a crash when an empty
~Copyabletype has a conditionalCopyableconformance.Scope: Fixes an assertion failure that could potentially lead to miscompiles in a release build.
Issue: rdar://125101955
Original PR: #72464
Risk: Low. One line bug fix.
Testing: Swift CI
Reviewer: @nate-chandler