Skip to content

Updates on lifetime dependence #72569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta enabled auto-merge March 25, 2024 21:08
@meg-gupta meg-gupta disabled auto-merge March 25, 2024 22:14
@meg-gupta meg-gupta changed the title Update some lifetime diagnostic messages Updates on lifetime dependence Mar 26, 2024
@meg-gupta
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion...

"cannot infer lifetime dependence, multiple parameters qualifiy as a candidate", ())
ERROR(lifetime_dependence_cannot_infer_no_candidates, none,
"cannot infer lifetime dependence, no parameters found that are "
"~Escapable or Escapable with a borrowing ownership",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still ambiguous. Maybe

no parameters found that are either ~Escapable or have borrowing ownership.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this as a followup

@meg-gupta meg-gupta merged commit 44b2c4d into swiftlang:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants