[6.0] AST: #if hasAttribute(retroactive) should evaluate true
#72573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `#if hasAttribute(...)` only accepted declaration attributes. It should also accept type attributes, like `@retroactive`. Resolves rdar://125195051
|
@swift-ci please test |
tshortli
added
🍒 release cherry pick
|
@swift-ci please test source compatibility |
bnbarham
approved these changes
Mar 26, 2024
|
The source compatibility failures appear to be existing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#if hasAttribute(...)only accepted declaration attributes. It should also accept type attributes, like@retroactive.hasAttributeswith any type attribute. Fixing this is important because multiple new type attributes are being introduced in Swift 6 (@retroactiveand@isolated) and package owners may need to conditionalize code that uses these attributes.#if hasAttribute(retroactive)should evaluate true #72571hasAttributechecks that failed due to this bug but will now unexpectedly succeed.