Sema: Fix existential-metatype-to-Any conversion #72762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit abae144.
We were incorrectly unwrapping too many levels of metatype, and our ErasureExpr would end up with conformances for the instance type and not the metatype itself. In the old universe, this was not a problem, but now Any has two protocol conformance members, so suddently this violated invariants. This was a regression, introduced in 6027bf4. Fixes rdar://125460667.
When erasing a pseudogeneric value in SILGen, we actually treat the value as if it had the type `any AnyObject`, while in Sema, it's an archetype. This requires SILGen to look up conformances again instead of using the ones in the ErasureExpr.
slavapestov
force-pushed
the
fix-rdar125460667
branch
from
1f448ba to
32dab83
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly unwrapping too many levels of metatype, and our ErasureExpr would end up with conformances for the instance type and not the metatype itself.
In the old universe, this was not a problem, but now Any has two protocol conformance members, so suddently this violated invariants.
I added a SILCloner test case that triggers the issue in the same way that it was originally observed, however subsequent commits in the PR add stronger assertions and with those assertions in place a bunch of tests failed already.
This was a regression, introduced in 6027bf4.
Fixes rdar://125460667.