[Concurrency] waitForAll and next of TaskGroups must inherit isolation #72794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
rjmccall,
DougGregor,
hborla and
angela-laar
and removed request for
a team and
rjmccall
ktoso
added
the
concurrency
|
Unblocked by #72813 |
ktoso
force-pushed
the
wip-waitForAll-isolation
branch
from
37e0e08 to
48cd829
Compare
|
@swift-ci please smoke test |
Otherwise we get warnings when task groups are used within an actor. Add global actor tests to cover the specific situation. resolves rdar://122846553
ktoso
force-pushed
the
wip-waitForAll-isolation
branch
from
48cd829 to
e8a61b9
Compare
|
@swift-ci please smoke test |
tshortli
reviewed
Apr 4, 2024
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get warnings when task groups are used within an actor. Add global actor tests to cover the specific situation:
To avoid this, we should keep the inherit the caller isolation.
resolves rdar://122846553